Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Karpenter - deploy in kube-system namespace #384

Closed
wants to merge 1 commit into from
Closed

Karpenter - deploy in kube-system namespace #384

wants to merge 1 commit into from

Conversation

erezzarum
Copy link

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

Since v0.33 it is recommended to deploy karpenter in the kube-system namespace

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@erezzarum erezzarum requested a review from a team as a code owner April 4, 2024 09:54
bryantbiggs
bryantbiggs reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this change tested and validated?

@erezzarum
Copy link
Author

How was this change tested and validated?

I have tested this locally when using the eks blueprints addons to migrate karpenter to the kube-system namespace.
Also validated karpenter was not affecting any workloads after this and workloads were success.

@bryantbiggs
Copy link
Contributor

and its not reporting any errors by Helm trying to create the existing namespace? https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/blob/7755fb6ec97139d34b7d01467ce7f20164cbd24a/main.tf#L3022C40-L3022C56

@erezzarum
Copy link
Author

and its not reporting any errors by Helm trying to create the existing namespace? https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/blob/7755fb6ec97139d34b7d01467ce7f20164cbd24a/main.tf#L3022C40-L3022C56

It didn't.

@erezzarum
Copy link
Author

I'm debating if this should be marked as breaking changes, as if there are other dependencies users might have on the karpenter namespace, such as scraping metrics from the karpenter controller, they should be aware that we changed the namespace.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label May 5, 2024
@github-actions GitHub Actions
Copy link

Pull request closed due to inactivity.

@github-actions github-actions bot closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs left review comments

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Karpenter - deploy in kube-system namespace
2 participants
@erezzarum @bryantbiggs